Review Request 123720: Fix autotests

David Edmundson david at davidedmundson.co.uk
Mon May 11 12:09:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123720/#review80216
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On May 11, 2015, 7:58 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123720/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 7:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> The kfiledialog_unittest was broken by me (sorry).
> 
> The kdirselectdialog_unittest timeouts because it shows warning message "Cannot list smb:/", probably because smb slave is not available.
> Changing it to trash slave (part of frameworks/kio) fixes the warning message and makes the test pass.
> 
> 
> Diffs
> -----
> 
>   autotests/kdirselectdialog_unittest.cpp bbbc958 
>   autotests/kfiledialog_unittest.cpp 30392bf 
> 
> Diff: https://git.reviewboard.kde.org/r/123720/diff/
> 
> 
> Testing
> -------
> 
> All tests now pass
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150511/e2e63c36/attachment.html>


More information about the Kde-frameworks-devel mailing list