Review Request 123595: Relax KUser test to allow for a "nogroup" group.

David Faure faure at kde.org
Mon May 11 08:02:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123595/
-----------------------------------------------------------

(Updated May 11, 2015, 8:02 a.m.)


Review request for KDE Frameworks and Marko Käning.


Changes
-------

Remove assumption of "nogroup" on Mac, relax test instead.


Summary (updated)
-----------------

Relax KUser test to allow for a "nogroup" group.


Repository: kcoreaddons


Description (updated)
-------

http://pig.made-it.com/uidgid.html shows that we can't rely on
what happens with an invalid id or group; on some systems they will
belong to a "nogroup" group.

REVIEW: 123595


Diffs (updated)
-----

  autotests/kusertest.cpp d17a2d3e97d5056524281eb18766377e48a0da35 

Diff: https://git.reviewboard.kde.org/r/123595/diff/


Testing
-------

Still passes on Linux; should fix the CI for mac, AFAICS.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150511/4d8cfa19/attachment.html>


More information about the Kde-frameworks-devel mailing list