Review Request 123700: Fix build with cmake 2.8.12.2

Jan Kundrát jkt at kde.org
Sun May 10 22:38:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123700/
-----------------------------------------------------------

(Updated May 10, 2015, 10:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, KDEPIM and Albert Astals Cid.


Changes
-------

Submitted with commit 1d00de33fb56137b94d19e0fb70aa7e03703751f by Jan Kundrát to branch master.


Bugs: 347399
    http://bugs.kde.org/show_bug.cgi?id=347399


Repository: kpeople


Description
-------

Fix build with cmake 2.8.12.2

Prior to 3.0, CMake didn't know how to handle the Q_GADGET macro, which
means that its presence was not enough to trigger automoc run on these
files. See [1] for a summary of the situation.

[1] https://mail.kde.org/pipermail/kde-frameworks-devel/2014-December/020713.html
BUG: 347399
REVIEW: 123700


Diffs
-----

  src/match.cpp f84a824 

Diff: https://git.reviewboard.kde.org/r/123700/diff/


Testing
-------


Thanks,

Jan Kundrát

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150510/d96e865c/attachment.html>


More information about the Kde-frameworks-devel mailing list