Review Request 123705: Add KConfigGui::setSessionConfig()
David Faure
faure at kde.org
Sun May 10 16:46:25 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123705/#review80176
-----------------------------------------------------------
Ship it!
So now we have a setter that returns a value ;)
Unusual, but ok, I'm not sure the alternative is better (setSessionConfig + calling sessionConfig() to get it).
src/gui/kconfiggui.h (line 68)
<https://git.reviewboard.kde.org/r/123705/#comment55013>
Needs to be more complete:
@deprecated since 5.11, use sessionConfig()->name()
- David Faure
On May 10, 2015, 4:01 p.m., Stefan Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123705/
> -----------------------------------------------------------
>
> (Updated May 10, 2015, 4:01 p.m.)
>
>
> Review request for KDE Frameworks and Rex Dieter.
>
>
> Bugs: 346768
> https://bugs.kde.org/show_bug.cgi?id=346768
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> When the application receives a saveState signal it needs to replace the current KConfig object with a new one based on the QSessionManager information. Add a new interface that accepts the session manager object.
>
>
> Diffs
> -----
>
> src/gui/kconfiggui.h 173400f
> src/gui/kconfiggui.cpp 0048c60
>
> Diff: https://git.reviewboard.kde.org/r/123705/diff/
>
>
> Testing
> -------
>
> On F22 with kwrite & konsole
>
>
> Thanks,
>
> Stefan Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150510/4604313c/attachment.html>
More information about the Kde-frameworks-devel
mailing list