Review Request 123706: Forward QSessionManager to KConfigGui

[Stefan Becker]

> On May 10, 2015, 1:18 p.m., David Faure wrote:
> > src/kmainwindow.cpp, line 151
> > <https://git.reviewboard.kde.org/r/123706/diff/2/?file=368023#file368023line151>
> >
> >     It does that, but on X11 only, and to "perform an initial checkpoint". Why not actually honour the request and save settings as requested? I guess it's useful in case the app crashes.
> >     
> >     Why does saving here orphan session files?
> >     Would QSessionManager::setDiscardCommand() help?

Doohhh, how obvious. Maybe I shouldn't have thought in "ksmserver" terms all the time. That means that "initial" is completely unneeded and we can rely on the setDiscardCommand() added in /r/123707


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123706/#review80164
-----------------------------------------------------------


On May 10, 2015, 2:39 p.m., Stefan Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123706/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 2:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Rex Dieter.
> 
> 
> Bugs: 346768
>     https://bugs.kde.org/show_bug.cgi?id=346768
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Get a KConfig object that corresponds to the QSessionManager object that is passed in with the saveStateRequest signal. To make sure that the data is stored to disk we have to call sync() on the object after the application has updated it.
> 
> 
> Diffs
> -----
> 
>   src/kmainwindow.cpp 15eecb7 
> 
> Diff: https://git.reviewboard.kde.org/r/123706/diff/
> 
> 
> Testing
> -------
> 
> On F22 with kwrite & konsole
> 
> 
> Thanks,
> 
> Stefan Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150510/8bacfd22/attachment-0001.html>