Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123705/#review80165
-----------------------------------------------------------



src/gui/kconfiggui.cpp (line 45)
<https://git.reviewboard.kde.org/r/123705/#comment55010>

    Ah, so basically sessionConfig() is used for restoring, while sessionConfig(QSessionManager) is used for saving. Right?
    
    Maybe the naming could be improved then, to make this clearer. I.e. the new method could be called  something like sessionSavingConfig(). And it should use a different pointer than the one used for restoring, maybe? There's little point in mixing the two, then.



src/gui/kconfiggui.cpp (line 74)
<https://git.reviewboard.kde.org/r/123705/#comment55011>

    So this method returns the config file for restoring or for saving depending on when it's called... sounds a bit unclean. Anyhow the only user of that method was the commented out code in kdelibs4support's kapplication.cpp.
    
    So I suggest we deprecate this method and tell people to use sessionConfig()->name() or sessionSavingConfig()->name() depending on what they wanted (restoring or saving).


- David Faure


On May 10, 2015, 10:30 a.m., Stefan Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123705/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 10:30 a.m.)
> 
> 
> Review request for KDE Frameworks and Rex Dieter.
> 
> 
> Bugs: 346768
>     https://bugs.kde.org/show_bug.cgi?id=346768
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> When the application receives a saveState signal it needs to replace the current KConfig object with a new one based on the QSessionManager information. Add a new variant that accepts the session manager object.
> 
> 
> Diffs
> -----
> 
>   src/gui/kconfiggui.h 173400f 
>   src/gui/kconfiggui.cpp 0048c60 
> 
> Diff: https://git.reviewboard.kde.org/r/123705/diff/
> 
> 
> Testing
> -------
> 
> On F22 with kwrite & konsole
> 
> 
> Thanks,
> 
> Stefan Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150510/eaf95358/attachment.html>