Review Request 123532: Add find modules for ModemManager and NetworkManager

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123532/#review80119
-----------------------------------------------------------


So the usual pattern for CMake find modules is to use pkgconfig as a hint, and use the find_library and find_path commands to do the actual finding (which should work even if pkg-config isn't installed).

See http://www.cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#find-modules for a tutorial. You should also look at the other find modules in e-c-m (which tend to make use of http://api.kde.org/ecm/module/ECMFindModuleHelpers.html)

- Alex Merry


On May 6, 2015, 8:12 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123532/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 8:12 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Lamarque Souza.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This patch adds FindModemManager.cmake and FindNetworkManager.cmake into other find modules. These are required for modemmanager-qt and networkmanager-qt, which are currently missing public dependencies on ModemManager/NetworkManager and to be able to add them, we need to have these find modules publicly available. Note, that my knowledge of CMake is quite limited, so proper review would be needed :).
> 
> 
> Diffs
> -----
> 
>   find-modules/FindModemManager.cmake PRE-CREATION 
>   find-modules/FindNetworkManager.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150509/5b6769b0/attachment.html>