Review Request 123493: Fix leaky incubation controller

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123493/
-----------------------------------------------------------

(Updated May 7, 2015, 9:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 3ec8ccd49943f513d5fbcb15ad169339360ad1a7 by David Edmundson to branch master.


Repository: kdeclarative


Description
-------

Docs for QQmlEngine explcitly say

"The engine can only have one active controller and it does not take
ownership of it." therefore we need to set a parent.

The incubator controls the deletion of generated objects, so this means we're leaking all QML items created by the KDeclarative::QmlObject.


Diffs
-----

  src/kdeclarative/qmlobject.cpp c483665c43985ba57459a880895ee8bf7ff92041 

Diff: https://git.reviewboard.kde.org/r/123493/diff/


Testing
-------

Plasma shell still loads and runs fine. Valgrind is a lot less angry.
Will merge after 5.10 to play safe.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150507/ff2f91db/attachment.html>