Review Request 123677: Bring back use of KEncodingFileDialog
David Rosca
nowrep at gmail.com
Thu May 7 21:14:38 UTC 2015
> On May 7, 2015, 8:48 p.m., David Rosca wrote:
> > Sorry, didn't know of the bug. Should I discard this rr?
>
> Christoph Feck wrote:
> Why? What you propose here was discussed as one possible option.
Yes, but from the bug discussion it seems reverting those commits is not something that Christoph Cullmann would agree with.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123677/#review80059
-----------------------------------------------------------
On May 7, 2015, 8:45 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123677/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 8:45 p.m.)
>
>
> Review request for Kate and KDE Frameworks.
>
>
> Bugs: 343255
> https://bugs.kde.org/show_bug.cgi?id=343255
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> This reverts commits 6e57274917f146ac233f50fcb902e8f2569bbbd2 (document/katedocument.cpp)
> and 4ef4063a34314480287540a0a4f58127bd6523f2 (link to KIOFileWidgets).
>
> It does use native file dialogs now (not sure if it didn't at the time of that commit). And mainly this fixes
> regression from KDE4, it is now possible to change encoding of files again.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 70c4d89
> src/document/katedocument.cpp 4f66a47
>
> Diff: https://git.reviewboard.kde.org/r/123677/diff/
>
>
> Testing
> -------
>
> Save file dialogs are working fine and saving to different encoding works too.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150507/4a77dc35/attachment.html>
More information about the Kde-frameworks-devel
mailing list