Review Request 123677: Bring back use of KEncodingFileDialog

David Rosca nowrep at gmail.com
Thu May 7 20:25:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123677/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: ktexteditor


Description
-------

This reverts commits 6e57274917f146ac233f50fcb902e8f2569bbbd2 (document/katedocument.cpp)
and 4ef4063a34314480287540a0a4f58127bd6523f2 (link to KIOFileWidgets).

It does use native file dialogs now (not sure if it didn't at the time of that commit). And mainly this fixes
regression from KDE4, it is now possible to change encoding of files again.


Diffs
-----

  src/CMakeLists.txt 70c4d89 
  src/document/katedocument.cpp 4f66a47 

Diff: https://git.reviewboard.kde.org/r/123677/diff/


Testing
-------

Save file dialogs are working fine and saving to different encoding works too.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150507/9d434c73/attachment.html>


More information about the Kde-frameworks-devel mailing list