Review Request 123669: Add KPluginLoader::findPluginsById convenience API
David Edmundson
david at davidedmundson.co.uk
Wed May 6 23:24:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123669/#review80001
-----------------------------------------------------------
+1 seems sensible.
autotests/kpluginloadertest.cpp (line 357)
<https://git.reviewboard.kde.org/r/123669/#comment54880>
not that it really matters, but invalid is spelt wrong.
Double the invalidity.
- David Edmundson
On May 6, 2015, 11:21 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123669/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 11:21 p.m.)
>
>
> Review request for KDE Frameworks, Alex Richardson and David Faure.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Add findPluginsById convenience API
>
> It's a quite common case to load a plugin from an ID. This makes it
> easy.
>
> CHANGELOG:New KPluginLoader::findPluginById() convenience API
> REVIEW:123669
>
>
> Diffs
> -----
>
> autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46
> src/lib/plugin/kpluginloader.h 124bfab7e207b17d3c8ab4d5a88321af476aad42
> src/lib/plugin/kpluginloader.cpp 4310d6cd7792329511f12b28d7c68b0fdd013538
>
> Diff: https://git.reviewboard.kde.org/r/123669/diff/
>
>
> Testing
> -------
>
> Added autotests, everything passes.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150506/838a426a/attachment.html>
More information about the Kde-frameworks-devel
mailing list