Review Request 123626: port libplasma away from sycoca as much as possible
Sebastian Kügler
sebas at kde.org
Wed May 6 23:22:27 UTC 2015
> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote:
> > I've read and tested it, everything still works nicely. Good job!
> >
> > I like how the patch moves much of the query language into simple C++, avoids a lot of query parsing and moves some of the error paths to compile time.
https://git.reviewboard.kde.org/r/123669/
This moves the filtering by id, which is quite common, into KPluginLoader to save us a bit of churn.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79999
-----------------------------------------------------------
On May 6, 2015, 5:21 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 5:21 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well
>
>
> Diffs
> -----
>
> KF5PlasmaConfig.cmake.in dee79ca
> src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43
> src/plasma/applet.cpp 2dda381
> src/plasma/containment.cpp 7eabbb8
> src/plasma/containmentactions.cpp f24bdac
> src/plasma/dataengine.cpp 4b3d671
> src/plasma/package.cpp 4e0be88
> src/plasma/packagestructure.cpp b2686b6
> src/plasma/pluginloader.cpp 0ce349a
> src/plasma/private/applet_p.cpp 2cbfd06
> src/plasma/private/dataenginemanager.cpp b9c5d8e
> src/plasma/scripting/appletscript.h 863d707
> src/plasma/scripting/dataenginescript.h f7ad3c2
> src/plasma/scripting/scriptengine.cpp cc407e7
> src/plasma/service.h b5d9b5a
> src/plasma/service.cpp 3e9d852
> src/plasmapkg/plasmapkg.cpp d606365
> src/scriptengines/CMakeLists.txt f566406
> src/scriptengines/qml/CMakeLists.txt e7130db
> src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d
> src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2
> src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd
> src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45
>
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
>
>
> Testing
> -------
>
> still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine
>
> latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150506/a484a53e/attachment.html>
More information about the Kde-frameworks-devel
mailing list