Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/#review79794
-----------------------------------------------------------


I'm confused, the title say "Remove KAboutData" and then goes and changes i18n while breaking it?

I mean i18n handling is relatively easy, and we have pretty good documentation at https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems on what to do, so i'm kind of sad of "this is not my issue, i'll just change stuff enough so that it 'works' for me and for someone else to fix it propertly" mindset.

So let me ask you, what are you missing from the above link that makes it hard for you to fix the i18n handling?

- Albert Astals Cid


On mai. 1, 2015, 7:18 p.m., Jerome Leclanche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122680/
> -----------------------------------------------------------
> 
> (Updated mai. 1, 2015, 7:18 p.m.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n), Albert Astals Cid, Martin Gräßlin, and Martin Klapetek.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> Remove the runtime's KAboutData
>     
> The about data was unexposed, but created a dependency on KCoreAddons (for
> KAboutData) and in turn on KI18n for the translations of the aboutData.
>     
> This removes both dependencies as well as the string extraction scripts.
> 
> --
> 
> Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
> like to, however it currently has too many dependencies. See
> https://github.com/lxde/lxqt/issues/507 for related discussion.
> I'm unsure myself if the about data is actually exposed somewhere I completely
> missed, but it doesn't look that way.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 68ad795 
>   src/runtime/CMakeLists.txt e639fa5 
>   src/runtime/globalshortcutsregistry.cpp 3e4d720 
>   src/runtime/kglobalacceld.cpp 4e7cb9d 
>   src/runtime/main.cpp fdf4d62 
> 
> Diff: https://git.reviewboard.kde.org/r/122680/diff/
> 
> 
> Testing
> -------
> 
> Compiles and runs. No further testing done.
> 
> 
> Thanks,
> 
> Jerome Leclanche
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150503/3ef0af0b/attachment.html>