Review Request 123590: ftp slave: Fix conditions for QFile::rename

[Boris Egorov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123590/
-----------------------------------------------------------

(Updated May 2, 2015, 8:38 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Add kdeframeworks as review group


Bugs: 343329
    https://bugs.kde.org/show_bug.cgi?id=343329


Repository: kio


Description
-------

QFile::rename returns true on success[1], so code should treat it
appropriately. Previously code shows an error when all worked fine.

    1: http://doc.qt.io/qt-5/qfile.html#rename


Diffs
-----

  src/ioslaves/ftp/ftp.cpp 7036f22 

Diff: https://git.reviewboard.kde.org/r/123590/diff/


Testing
-------

Tested with kioexec and Kate.

    kioexec cat ftp://ftp.gnu.org/welcome.msg
    kate ftp://ftp.gnu.org/welcome.msg
    
File from ftp loads and showed successfully.


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150502/95dc56cc/attachment.html>