Review Request 123111: Only add a '/' if the url does not end with one

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123111/#review78189
-----------------------------------------------------------


toString() is slow and wrong (e.g. the trailing slash could come from a query or fragment). Why not use path() instead? That's what KDirModel uses, surely.

The difference between smb: and smb:// is the host being null vs empty, IIRC. But I'm quite sure KDirModel doesn't care about that...


autotests/kdirselectdialog_unittest.cpp (line 46)
<https://git.reviewboard.kde.org/r/123111/#comment53570>

    red in reviewboard :)



src/platformtheme/kdirselectdialog.cpp (line 466)
<https://git.reviewboard.kde.org/r/123111/#comment53573>

    A big change from before is that ftp://host/home/user/subdir will now remain like that instead of becoming ftp://host/ as before. Is this wanted? In any case, it should be added to the unittest.



src/platformtheme/kdirselectdialog.cpp (line 467)
<https://git.reviewboard.kde.org/r/123111/#comment53571>

    While being here, please remove that "portability" note. "/" is fine in urls, even on Windows.



src/platformtheme/kdirselectdialog_p.h (line 62)
<https://git.reviewboard.kde.org/r/123111/#comment53572>

    red (trailing spaces)


- David Faure


On March 23, 2015, 12:30 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123111/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 12:30 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> I could not figure out any other way of knowing if the path ends with '/' than calling toString so that is what I am doing.
> 
> This patch adds a test with 3 different data that now behave correctly, before smb: and smb:// were failing.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt e8ed6a9 
>   autotests/kdirselectdialog_unittest.cpp PRE-CREATION 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 8b5c77a 
> 
> Diff: https://git.reviewboard.kde.org/r/123111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150329/5f18a59d/attachment-0001.html>