Review Request 123156: Don't warn the user/developer about something he can't fix

David Edmundson david at davidedmundson.co.uk
Fri Mar 27 23:53:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123156/#review78130
-----------------------------------------------------------

Ship it!


the file is full of commented out debug everywhere else already

- David Edmundson


On March 27, 2015, 10:47 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123156/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 10:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> image formats are loaded via qimage/qimagereader and friends, the user/developer does not choose which ones will be used so giving him a warning about sequential devices not being supported is not going to help anyone, only spam their shell/logs.
> 
> 
> Diffs
> -----
> 
>   src/imageformats/ras.cpp 9d8bb32 
> 
> Diff: https://git.reviewboard.kde.org/r/123156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150327/b786c765/attachment.html>


More information about the Kde-frameworks-devel mailing list