Review Request 122887: Load and wrap the QML-only version of kcms if possible
Marco Martin
notmart at gmail.com
Mon Mar 23 12:43:17 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122887/
-----------------------------------------------------------
(Updated March 23, 2015, 12:43 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit 85ab5f968bce4a8b78ac1f2603d442f851ae1368 by Marco Martin to branch master.
Repository: kcmutils
Description
-------
This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols).
This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule
Diffs
-----
CMakeLists.txt cb4ae5d
src/CMakeLists.txt f7b869f
src/kcmoduleloader.cpp 5ccf236
src/kcmoduleqml.cpp PRE-CREATION
src/kcmoduleqml_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122887/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150323/fe8e7e6f/attachment.html>
More information about the Kde-frameworks-devel
mailing list