[Kde-games-devel] Data migration issue

[Albert Astals Cid]

El Diumenge, 22 de març de 2015, a les 21:41:02, Albert Astals Cid va 
escriure:
> El Diumenge, 22 de març de 2015, a les 18:19:46, David Faure va escriure:
> > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote:
> > > Too late for KDE Applications 15.04 though now that i think, so maybe we
> > > actually have to suggest everybody using the migrator to add those extra
> > > lines?
> > 
> > OK, that means:
> > 
> > --- a/src/lib/util/kdelibs4configmigrator.h
> > +++ b/src/lib/util/kdelibs4configmigrator.h
> > 
> > @@ -60,6 +60,10 @@ public:
> >       *    look for old data to migrate as well
> >       * }
> >       * @endcode
> > 
> > +     *
> > +     * IMPORTANT: after migrate() returns true, call
> > KSharedConfig::openConfig()->reparseConfiguration() +     * so that the
> > global config (very likely already created by e.g. the platform
> > integration
> > plugin) +     * can see the migrated data.
> > 
> >       */
> >      
> >      bool migrate();
> > 
> > But wait, this makes me realize another solution: kdelibs4configmigrator
> > could load the framework integration plugin, which would take care of
> > this,
> > if installed.
> > 
> > Patch attached. Tested, at least to the extent that the slot is indeed
> > being called.
> > 
> > Obviously that's still "too late for KDE Applications 15.04", so maybe fix
> > the apps that you want to see fixed for 15.04 with a
> > #if KCOREADDONS_VERSION < 0x050900
> > KSharedConfig::openConfig()->reparseConfiguration();
> > #endif
> > 
> > and KF 5.9 will make this unnecessary, i.e. the doc change won't get
> > committed.
> > 
> > Any input?
> 
> That adds a silent dependency from kcoreaddons to frameworksintegration,
> which feels a bit weird to me...
> 
> ...but on the hard hand, it is true that the "bug" is in

hard hand -> other hand, no idea what i was thinking

> frameworksintegration itself because it opens the shared config before the
> migrator has had time to act (i.e. if you don't use the
> frameworksintegration platform plugin the bug is not there)
> 
> So yes i agree this makes sense to go with this for frameworks 5.9 :)
> 
> And actually this is also good enough for KDE Applications 15.04 since
> frameworks 5.9 is supposed to go out before it.
> 
> Good idea!
> 
> Cheers,
>   Albert
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel