Review Request 123075: do not require X11 on Mac OS X

[Martin Gräßlin]

> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
> 
> Martin Gräßlin wrote:
>     To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed.
> 
> Christoph Cullmann wrote:
>     Actually, you don't want that it is optional as you really don't want that it ever is found on MacOS. If you install an XQuartz for legacy apps, it will be found, and you will have a completly mess as result ;=)
> 
> Martin Gräßlin wrote:
>     Christoph, that argument is wrong. The same would be the case with Windows and any other platform which optionally offers X11 (this includes Linux!). CMake can handle the situation quite well to disable an unwanted build dependency. If a user installs XLib headers (which is not the same as just installing XQuartz) we should expect the user to disable the cmake build option.
> 
> Christoph Cullmann wrote:
>     That means that nobody will get a senseful build on Mac, if he doesn't disable that optional dependency. Thats the opposite of a normal optional dependency, that leads to missing features if not found but not complete mess if found.
>     I tried to compile frameworks stuff on Mac, and IMHO, really, that makes it close to unusable, that you need to tweak each cmake call just to have something usable, if you have too much stuff installed. I never had to do that on Linux/Other Unices.

> That means that nobody will get a senseful build on Mac

What since when is XLib as a build dependency available by default on OS X?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/#review77779
-----------------------------------------------------------


On March 19, 2015, 11:59 p.m., Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123075/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 11:59 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Palimaka.
> 
> 
> Repository: kdesu
> 
> 
> Description
> -------
> 
> do not require X11 on Mac OS X
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9623483d6f11f9cdb7d7dc19decfd7cf5e86d079 
> 
> Diff: https://git.reviewboard.kde.org/r/123075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150320/45ea8540/attachment.html>