Review Request 123031: Let Kross be useable w/o searching for private deps

[Hrvoje Senjan]

> On March 18, 2015, 8:40 p.m., Christophe Giboudeaux wrote:
> > KF5KrossConfig.cmake.in, line 9
> > <https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9>
> >
> >     Are you sure ?
> >     
> >     ./ui/actioncollectionview.h:27:#include <QWidget>
> 
> Hrvoje Senjan wrote:
>     this is now similar (reverse) as with kpeople review request. do we find the public deps for all targets, or for the 'minimal' one?
> 
> Christophe Giboudeaux wrote:
>     Maybe I misunderstood the find_dependency goal but it sounds to me that if you #include a file in your installed header, it becomes de facto a dependency

Agreed. But some frameworks have more targets, and one can use only one of those. So i guess the question is (in general), shall the deps for whole framework be searched, or only for the 'core' one?


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123031/#review77700
-----------------------------------------------------------


On March 18, 2015, 9:13 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123031/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 9:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> Only search for public deps in cmake config
> 
> 
> Diffs
> -----
> 
>   KF5KrossConfig.cmake.in e89cee2 
> 
> Diff: https://git.reviewboard.kde.org/r/123031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150318/6c268d14/attachment-0001.html>