Review Request 122828: Be more explicit regarding KBookmarks deps
Hrvoje Senjan
hrvoje.senjan at gmail.com
Wed Mar 18 20:36:41 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122828/
-----------------------------------------------------------
(Updated March 18, 2015, 8:36 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
-------
Submitted with commit 14ec99b72ec8f71f0b3bf3486808370dea3b8be9 by Hrvoje Senjan to branch master.
Repository: kbookmarks
Description
-------
this adds KWidetsAddons to public linker flags, but also reduces number of frameworks needed for KBookmarks to be useable.
removal of kconfig.h could be considered a minor SiC, though e.g. kio & kio-extras built fine with this change
Diffs
-----
CMakeLists.txt 4b5a25c
KF5BookmarksConfig.cmake.in 8a14d7d
src/CMakeLists.txt 23e3709
src/kbookmarkimporter.h 3f15040
src/kbookmarkmanager.cpp 7c5fa2d
Diff: https://git.reviewboard.kde.org/r/122828/diff/
Testing
-------
Thanks,
Hrvoje Senjan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150318/70e9fb35/attachment.html>
More information about the Kde-frameworks-devel
mailing list