Review Request 120393: [kdelibs4support] Kill dead code

Hrvoje Senjan hrvoje.senjan at gmail.com
Wed Mar 18 18:24:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120393/
-----------------------------------------------------------

(Updated March 18, 2015, 7:24 p.m.)


Review request for KDE Frameworks, David Faure and Vishesh Handa.


Changes
-------

bring back accidentally removed #else case


Repository: kdelibs4support


Description
-------

Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled.


Diffs (updated)
-----

  autotests/kfilemetainfotest.cpp c751cdd 
  src/CMakeLists.txt b662893 
  src/config-kdelibs4support.h.cmake 1af3ee0 
  src/kio/kfilemetadataconfigurationwidget.cpp 259b205 
  src/kio/kfilemetadataprovider.cpp 3468546 
  src/kio/kfilemetadataprovider_p.h 31137b2 
  src/kio/kfilemetadatawidget.cpp 1edb069 
  src/kio/kfilemetainfo.cpp eae1295 
  src/kio/kfilemetainfoitem.cpp 62f760d 
  src/kio/kfilemetainfoitem_p.h 8929e46 
  src/kio/knfotranslator.cpp 8eec6a1 

Diff: https://git.reviewboard.kde.org/r/120393/diff/


Testing
-------


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150318/c209ce01/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list