Review Request 123032: Search for public dep in KPeople's cmake config

Aleix Pol Gonzalez aleixpol at kde.org
Wed Mar 18 18:18:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123032/#review77696
-----------------------------------------------------------


You can use KPeople without Qt5Widgets, I don't think this is correct...

- Aleix Pol Gonzalez


On March 18, 2015, 6:34 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123032/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 6:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> Both KF5::PeopleBackend and KF5::PeopleWidgets need Qt5Widgets publicly, so search them.
> 
> 
> Diffs
> -----
> 
>   KF5PeopleConfig.cmake.in 05ae340 
> 
> Diff: https://git.reviewboard.kde.org/r/123032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150318/4e5ea3df/attachment.html>


More information about the Kde-frameworks-devel mailing list