Review Request 122970: Move added setError method to new JobViewV3 interface

David Rosca nowrep at gmail.com
Wed Mar 18 10:15:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122970/#review77674
-----------------------------------------------------------


Bump

- David Rosca


On March 15, 2015, 4:56 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122970/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 4:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> This fixes source compatibility from https://git.reviewboard.kde.org/r/122926/
> 
> It adds a new org.kde.JobViewV3.xml file. The DBus interface name is still JobViewV2 to keep compatibility with apps still using org.kde.JobViewV2.xml.
> It also removes generating code from old org.kde.JobView.xml as it is not used anywhere.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c539bdc 
>   src/kuiserverjobtracker.cpp 7f13a4d 
>   src/kuiserverjobtracker_p.h daf3902 
>   src/org.kde.JobViewV2.xml 245a5f0 
>   src/org.kde.JobViewV3.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122970/diff/
> 
> 
> Testing
> -------
> 
> plasma-workspace stable now builds fine
> changing V2 -> V3 in CMakeFiles.txt in master branch enable the new setError method.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150318/fffe8d17/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list