Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77606
-----------------------------------------------------------


Could you please add another test case in kglobalshortcuttests for this method?


src/kglobalaccel.h
<https://git.reviewboard.kde.org/r/122981/#comment53297>

    please add an
    @since
    and
    @param



src/kglobalaccel.h
<https://git.reviewboard.kde.org/r/122981/#comment53296>

    what are the "some cases"?


- Martin Gräßlin


On March 16, 2015, 9:29 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122981/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 9:29 p.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> In some cases you need to call loadShortcutFromGlobalSettings() in order not to get a an empty list when calling shortcut(). See discussion in https://git.reviewboard.kde.org/r/122249/.
> 
> 
> Diffs
> -----
> 
>   src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 
>   src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122981/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150317/db3a636a/attachment.html>