Review Request 122978: Add unit test for crash of bug 343976

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122978/
-----------------------------------------------------------

Review request for KDE Frameworks.


Bugs: 343976
    https://bugs.kde.org/show_bug.cgi?id=343976


Repository: frameworkintegration


Description
-------

Use a QPointer for QMenu of SystemTrayMenu

We need better memory management as the QMenu the SystemTrayMenu creates
might be deleted externally causing a double delete if the so-far
QScopedPoiter cleans up.

Switch to QPointer and call deleteLater if the pointer is still valid
during destroying the SystemTrayMenu.

BUG: 343976
CHANGELOG: Fix possible crash when destroying a QSystemTrayIcon (triggered by Trojita)


Diffs
-----

  autotests/CMakeLists.txt e8ed6a99bb45969231ba21b8c5588e093bbbe3ee 
  autotests/ksni_unittest.cpp PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.h 8f13a36ae7cebed7499ce8a160f3533665b909ac 
  src/platformtheme/kdeplatformsystemtrayicon.cpp ce3d3de9f9cf479a5fe3af65ef7fb8ec2b9e0d29 

Diff: https://git.reviewboard.kde.org/r/122978/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150316/be33f5da/attachment.html>