Review Request 122926: Add setError method to JobViewV2 interface

[Albert Astals Cid]

> On mar. 15, 2015, 11:10 a.m., Bhushan Shah wrote:
> > Umm; this seems to break source compatibilty maybe? For example plasma-workspace Plasma/5.2 branch which compiled with older revisions fine seems to fail with this commit
> > 
> > 23:07:43 Building CXX object applets/systemtray/plugin/CMakeFiles/systemtrayplugin.dir/tasklistmodel.cpp.o
> > 23:07:44 [ 74%] /srv/jenkins/workspace/plasma-workspace_stable_qt5/build/dataengines/applicationjobs/jobviewadaptor.cpp: In member function ‘void JobViewV2Adaptor::setError(uint)’:
> > 23:07:44 /srv/jenkins/workspace/plasma-workspace_stable_qt5/build/dataengines/applicationjobs/jobviewadaptor.cpp:57:15: error: ‘class JobView’ has no member named ‘setError’
> > 23:07:44      parent()->setError(errorCode);
> > 23:07:44                ^
> > 
> > See http://build.kde.org/job/plasma-workspace_stable_qt5/89/console
> 
> David Rosca wrote:
>     It does break source compatibility when used with qt5_add_dbus_adaptor, unfortunately.
>     It can be fixed in plasma-workspace by adding an empty setError(uint) method to classes using the adaptor, or revert this commit and introduce a JobViewV3.

Breaking source compatibility in a framework seems like a bad idea to me.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122926/#review77503
-----------------------------------------------------------


On mar. 13, 2015, 7:26 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122926/
> -----------------------------------------------------------
> 
> (Updated mar. 13, 2015, 7:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> -------
> 
> Currently, there is no way to retrieve value of KJob::error().
> This patch adds a setError method to JobViewV2 interface that fixes the issue.
> 
> This is needed to correctly handle job errors in notifications plasmoid.
> If this gets accepted, I will create a review request for plasma-workspace (changes in kuiserver, dataengine and notifications plasmoid).
> 
> 
> Diffs
> -----
> 
>   src/kuiserverjobtracker.cpp 191359b 
>   src/org.kde.JobViewV2.xml cacb5e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122926/diff/
> 
> 
> Testing
> -------
> 
> Works fine with patched plasma-workspace
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150315/a00a6e9e/attachment.html>