Review Request 122918: revert 2ee76f0 to fix QtQuickControls

[Jeremy Whiting]

> On March 15, 2015, 2:21 a.m., Frederik Gladhorn wrote:
> > Without testing anything, I think that this will break QWidget's file dialog when set to modal. Iirc this breaks for example the open dialogs in qt creator.

Yeah, that's the wrong approach, though I'm not sure what the right one is unfortunately. I tried to fix this bug with https://git.reviewboard.kde.org/r/121098/ but that change broke other things. It is very annoying and causes me issues almost daily since I can't upload anything from chromium currently (It's invocation of kdialog shows the open file dialog, but it's not interactive at all and has to be closed).

Bug BUG:334963 has some information about the problem also.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122918/#review77498
-----------------------------------------------------------


On March 12, 2015, 7:19 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122918/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 7:19 a.m.)
> 
> 
> Review request for KDE Frameworks and Frederik Gladhorn.
> 
> 
> Bugs: 345002
>     https://bugs.kde.org/show_bug.cgi?id=345002
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Not sure it's the right approach, but right now, the FileDialog QtQuickControls will be broken in the kde interqation if set as modal, see
> https://bugs.kde.org/show_bug.cgi?id=345002
> 
> the commit 2ee76f0 makes show() not do anything in that case, and the FileDialog QML bindings seems to assume to call only show()
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 9ffb1d9 
> 
> Diff: https://git.reviewboard.kde.org/r/122918/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150315/d2ed57e3/attachment.html>