Review Request 122953: Let KNewStuff be useable w/o searching for private deps

[Hrvoje Senjan]

> On March 14, 2015, 8:10 p.m., Jeremy Whiting wrote:
> > I'm not sure I understand what this is for. If you try to build with knewstuff and kio and karchive aren't present, it wont run properly. Is this to make stuff that uses knewstuff build when the dependencies are there, but their headers are missing or something?

if i want to implement something with knewstuff, in principle i shouldn't need karchive and kio headers, etc. - unless i want also access to their API, but then i'll search for them explicitly. this mostly makes a difference for packagers, and users of packages; frameworks devs will have all of KF5 built anyway.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122953/#review77472
-----------------------------------------------------------


On March 14, 2015, 8:06 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122953/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 8:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> KF5Archive and KF5KIO are private deps, don't search for them in config
> 
> 
> Diffs
> -----
> 
>   KF5NewStuffConfig.cmake.in bbbfdd0 
> 
> Diff: https://git.reviewboard.kde.org/r/122953/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150314/ec56635f/attachment.html>