Review Request 122893: Populate KIconDialog on showEvent

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122893/
-----------------------------------------------------------

(Updated März 12, 2015, 7:10 nachm.)


Review request for KDE Frameworks.


Changes
-------

Remove spontaneous check. I think I misunderstood what it was all about.


Repository: kiconthemes


Description
-------

Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then.

I don't know whether this is binary compatible. "you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one"


Diffs (updated)
-----

  src/kicondialog.h ee4edca 
  src/kicondialog.cpp 7a6c1f1 

Diff: https://git.reviewboard.kde.org/r/122893/diff/


Testing
-------

Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/7f78a87f/attachment.html>