Review Request 122918: revert 2ee76f0 to fix QtQuickControls

Marco Martin notmart at gmail.com
Thu Mar 12 13:19:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122918/
-----------------------------------------------------------

Review request for KDE Frameworks and Frederik Gladhorn.


Bugs: 345002
    https://bugs.kde.org/show_bug.cgi?id=345002


Repository: frameworkintegration


Description
-------

Not sure it's the right approach, but right now, the FileDialog QtQuickControls will be broken in the kde interqation if set as modal, see
https://bugs.kde.org/show_bug.cgi?id=345002

the commit 2ee76f0 makes show() not do anything in that case, and the FileDialog QML bindings seems to assume to call only show()


Diffs
-----

  src/platformtheme/kdeplatformfiledialoghelper.cpp 9ffb1d9 

Diff: https://git.reviewboard.kde.org/r/122918/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/43b53b09/attachment.html>


More information about the Kde-frameworks-devel mailing list