Review Request 122913: Added an event() version that takes no icon and will use a default one

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122913/#review77350
-----------------------------------------------------------


Small nitpick.


src/knotification.cpp
<https://git.reviewboard.kde.org/r/122913/#comment53119>

    Those should be QStringLiteral, as you are constructing a QString.


- Aleix Pol Gonzalez


On March 12, 2015, 4:37 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122913/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 4:37 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Added an event() version that takes no icon and will use a default one depending on the notification type
> 
> 
> Diffs
> -----
> 
>   src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 
>   src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 
> 
> Diff: https://git.reviewboard.kde.org/r/122913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/6be2a17b/attachment.html>