Review Request 122876: Delay notifications a bit on Plasma startup

[Martin Klapetek]

> On March 12, 2015, 8:48 a.m., Martin Gräßlin wrote:
> > timer looks wrong to me, too. Not because it's ugly, but because Plasma notifications will not go above the splash screen. The fallback might be ugly, but as I have seen: it goes above the splash screen.
> > 
> > Thus I suggest that we implement missing pieces to figure out whether we are in startup and only show if startup is done.

I'm all for it, but note that splash screen is terminated once Plasma starts, there should never be a case of Plasma running and being fully covered by the splash screen.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122876/#review77324
-----------------------------------------------------------


On March 9, 2015, 8:03 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122876/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 8:03 p.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Bugs: 344903
>     https://bugs.kde.org/show_bug.cgi?id=344903
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Currently when something is started right after login and spawns a notification, an ugly popup (KPassivePopup fallback) will appear over the splash screen as the org.freedesktop.Notifications service is not ready yet. 
> 
> This patch delays the notifications by max 25 seconds if and only if KDE_FULL_SESSION is set and there's no Plasma (org.kde.plasmashell) running. If the org.freedesktop.Notifications does not appear within those 25 seconds, the notifications will be put on screen using KPassivePopup.
> 
> Ideally this should also check if ksmserver is in the "starting phase", but I haven't found a way to check for that. Suggestions welcome.
> 
> 
> Diffs
> -----
> 
>   src/notifybypopup.h 416c533 
>   src/notifybypopup.cpp 316ff2b 
> 
> Diff: https://git.reviewboard.kde.org/r/122876/diff/
> 
> 
> Testing
> -------
> 
> Plasma not running, emitted KNotification, nothing, started Plasma, notifications appeared when Plasma loaded.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/6f91b564/attachment.html>