Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

[Albert Vaca Cintora]

> On mar. 9, 2015, 11:20 a.m., Martin Klapetek wrote:
> > Ship It!
> 
> Martin Klapetek wrote:
>     Actually wait, StandardEvents should have standard icons, why would you need to change them?
> 
> Albert Vaca Cintora wrote:
>     They don't have a standard, default icon: you have to specify it and as of now the only way you have for it is with a QPixmap.
> 
> Martin Klapetek wrote:
>     Indeed, you are correct. Ship this then, it makes sense to have an alternative for the QPixmap only.
>     
>     Another overload should be added that actually uses the default icons automatically though. Would you be up for that?

Sure: https://git.reviewboard.kde.org/r/122913/


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122864/#review77205
-----------------------------------------------------------


On mar. 9, 2015, 6:02 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122864/
> -----------------------------------------------------------
> 
> (Updated mar. 9, 2015, 6:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> This allows to use icon names instead of QPixmaps when using StandardEvents
> instead of app-defined events.
> 
> 
> Diffs
> -----
> 
>   src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 
>   src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 
> 
> Diff: https://git.reviewboard.kde.org/r/122864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150312/98c2e396/attachment.html>