Review Request 122590: Guard kglobalaccel against QApplication

Kai Uwe Broulik kde at privat.broulik.de
Tue Mar 10 21:21:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/
-----------------------------------------------------------

(Updated March 10, 2015, 9:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.


Changes
-------

Submitted with commit dcb5c0403c5caad901a46b2ae496078af0a90d12 by Kai Uwe Broulik to branch master.


Repository: kglobalaccel


Description
-------

KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.


Diffs
-----

  src/kglobalaccel.h 4a5595f 
  src/kglobalaccel.cpp d123af4 
  src/kglobalaccel_p.h b1528dc 

Diff: https://git.reviewboard.kde.org/r/122590/diff/


Testing
-------

screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150310/7e26ce33/attachment.html>


More information about the Kde-frameworks-devel mailing list