Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

Christoph Feck cfeck at kde.org
Mon Mar 9 20:29:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122875/#review77228
-----------------------------------------------------------



src/kiconengine.cpp
<https://git.reviewboard.kde.org/r/122875/#comment53034>

    Please use spaces around binary '*' operator.


- Christoph Feck


On March 9, 2015, 5:54 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122875/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> This now matches the behaviour of QPixmapIconEngine::paint
> 
> 
> Diffs
> -----
> 
>   src/kiconengine.cpp 6dff533 
> 
> Diff: https://git.reviewboard.kde.org/r/122875/diff/
> 
> 
> Testing
> -------
> 
> Opened configure toolbars in konversation with QT_DEVICE_PIXEL_RATIO=2
> QStyledItemDelegate calls QIcon::paint which ends up going through this code with our QPA.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150309/6faca2d4/attachment.html>


More information about the Kde-frameworks-devel mailing list