Review Request 122876: Delay notifications a bit on Plasma startup
Martin Klapetek
martin.klapetek at gmail.com
Mon Mar 9 19:37:20 UTC 2015
> On March 9, 2015, 8:32 p.m., Aleix Pol Gonzalez wrote:
> > Can't we use the same mechanism as when the screen is locked? (We do that, right? show the notifications after going out of lock).
> >
> > Having a timer is kind of hacky...
I'm not aware of us doing that (and we don't, I've just tested).
However, when Plasma starts, the timer is stopped and the queue processed right away. If Plasma will not start, it's the same as DBus timeout...
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122876/#review77226
-----------------------------------------------------------
On March 9, 2015, 8:03 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122876/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 8:03 p.m.)
>
>
> Review request for KDE Frameworks and Eike Hein.
>
>
> Bugs: 344903
> https://bugs.kde.org/show_bug.cgi?id=344903
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Currently when something is started right after login and spawns a notification, an ugly popup (KPassivePopup fallback) will appear over the splash screen as the org.freedesktop.Notifications service is not ready yet.
>
> This patch delays the notifications by max 25 seconds if and only if KDE_FULL_SESSION is set and there's no Plasma (org.kde.plasmashell) running. If the org.freedesktop.Notifications does not appear within those 25 seconds, the notifications will be put on screen using KPassivePopup.
>
> Ideally this should also check if ksmserver is in the "starting phase", but I haven't found a way to check for that. Suggestions welcome.
>
>
> Diffs
> -----
>
> src/notifybypopup.h 416c533
> src/notifybypopup.cpp 316ff2b
>
> Diff: https://git.reviewboard.kde.org/r/122876/diff/
>
>
> Testing
> -------
>
> Plasma not running, emitted KNotification, nothing, started Plasma, notifications appeared when Plasma loaded.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150309/642edbe6/attachment.html>
More information about the Kde-frameworks-devel
mailing list