Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122875/#review77223
-----------------------------------------------------------


makes no sense to me, you are getting a rect to 
paint on and painting outside of it.

what even warrants that there will be "space"
on the qpainter?

should the size increase be done in upper levels?

- Albert Astals Cid


On mar. 9, 2015, 5:54 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122875/
> -----------------------------------------------------------
> 
> (Updated mar. 9, 2015, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> This now matches the behaviour of QPixmapIconEngine::paint
> 
> 
> Diffs
> -----
> 
>   src/kiconengine.cpp 6dff533 
> 
> Diff: https://git.reviewboard.kde.org/r/122875/diff/
> 
> 
> Testing
> -------
> 
> Opened configure toolbars in konversation with QT_DEVICE_PIXEL_RATIO=2
> QStyledItemDelegate calls QIcon::paint which ends up going through this code with our QPA.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150309/467fdab4/attachment.html>