Review Request 122576: Introduce KMoreTools

[Gregor Mi]

> On March 7, 2015, 9:04 a.m., David Faure wrote:
> > KService is basically ksycoca. One day I hope we can move away from that, which means all of kservice could then be deprecated.
> > So it still makes sense to *use* kservice where looking up desktop files is needed (it's our current implementation of that) but KMT itself isn't part of the ksycoca technology, it should be higher up in the stack.
> > 
> > One idea would be to put it in KNewStuff. It's the same kind of thing, viewed from far away: offering the user to install more  stuff.
> 
> Gregor Mi wrote:
>     Regarding the lookup if an application is installed or not. Currently this is done by looking if the desktop file is installed. With respect to [Dolphin (frameworks branch) doesn’t find filelight](https://bugs.kde.org/show_bug.cgi?id=344614) and that you said it is better to move away from ksyscoca, I wonder how stable the detection of desktop files currently is? Is it maybe better to detect if the executable exists which is specified at the desktop file's Exec line?
> 
> David Faure wrote:
>     You misunderstood me. Right now the recommended solution *is* KService and ksycoca. It is supposed to work, and works for many cases. I didn't have time to look into this specific bug report, but unit tests pass and many people run a plasma 2 desktop based on KService and ksycoca.
>     
>     I'm just saying that in the long term I want to be able to replace this technology with something else, but that's just long-term architectural thinking. For now, use it and debug it ;-)

Ok. So there is no way around the debugging part. ;-)


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review77147
-----------------------------------------------------------


On March 1, 2015, 2:28 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122576/
> -----------------------------------------------------------
> 
> (Updated March 1, 2015, 2:28 p.m.)
> 
> 
> Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/
> 
> Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework
> 
> If KMoreTools is considered useful it needs a home. I placed it in KService for now.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 
>   src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 
>   src/kmoretools/kmoretools.h PRE-CREATION 
>   src/kmoretools/kmoretools.cpp PRE-CREATION 
>   src/kmoretools/kmoretools_p.h PRE-CREATION 
>   src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION 
>   src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION 
>   src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION 
>   tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e 
>   tests/kmoretools/1/a.desktop PRE-CREATION 
>   tests/kmoretools/1/b.desktop PRE-CREATION 
>   tests/kmoretools/1/c.desktop PRE-CREATION 
>   tests/kmoretools/2/kate.desktop PRE-CREATION 
>   tests/kmoretools/2/kate.png PRE-CREATION 
>   tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION 
>   tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION 
>   tests/kmoretools/kmoretoolstest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122576/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150309/b7a016a8/attachment-0001.html>