Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/#review77148
-----------------------------------------------------------



src/widgets/kurlcombobox.cpp
<https://git.reviewboard.kde.org/r/122613/#comment53006>

    A better check would be
    
    if (!url.path().isEmpty() && ...)
    
    The reasoning being that "empty path isn't the same as /" (e.g. for FTP, empty path means $HOME on the ftp server, while / is the root).
    
    i.e. add this testcase:
    ftp://user@example.com
    This should not turn into ftp://user@example.com/


- David Faure


On Feb. 18, 2015, 8:46 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122613/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 8:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt f613c1a 
>   autotests/kurlcomboboxtest.h PRE-CREATION 
>   autotests/kurlcomboboxtest.cpp PRE-CREATION 
>   src/widgets/kurlcombobox.cpp ed5b8a2 
> 
> Diff: https://git.reviewboard.kde.org/r/122613/diff/
> 
> 
> Testing
> -------
> 
> Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150307/ede598fc/attachment-0001.html>