Review Request 122843: Mark QuickAddons as its own project.

[Aleix Pol Gonzalez]

> On March 6, 2015, 5:17 p.m., Aleix Pol Gonzalez wrote:
> > src/quickaddons/CMakeLists.txt, line 22
> > <https://git.reviewboard.kde.org/r/122843/diff/1/?file=353379#file353379line22>
> >
> >     Isn't this redundant, then?
> 
> Michael Palimaka wrote:
>     It builds fine with it removed. I don't know enough about it to comment otherwise.

Please do so, then. Instead of adding the project() thing, just remove the mention.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122843/#review77117
-----------------------------------------------------------


On March 6, 2015, 5:07 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122843/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 5:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Otherwise, QuickAddons_BINARY_DIR is undefined causing -I/.. to be passed to the
> compiler, which can cause a build failure.
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 
> 
> Diff: https://git.reviewboard.kde.org/r/122843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150306/fc7ce983/attachment-0001.html>