Review Request 122843: Mark QuickAddons as its own project.

[Jan Kundrát]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122843/#review77116
-----------------------------------------------------------


To expland a bit, the reason for -I/.. being wrong is that it messes up include paths in a harmful way on some systems. C++ stdlib from GCC 4.8 ships with stuff such as #include <debug/foo>, and if there's an empty mountpoint /debug with too-strict permissions, the build fails (see e.g. https://bugs.gentoo.org/show_bug.cgi?id=542298).

Thanks for debugging this!

- Jan Kundrát


On March 6, 2015, 4:07 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122843/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Otherwise, QuickAddons_BINARY_DIR is undefined causing -I/.. to be passed to the
> compiler, which can cause a build failure.
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 
> 
> Diff: https://git.reviewboard.kde.org/r/122843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150306/455aff74/attachment.html>