Review Request 122590: Guard kglobalaccel against QApplication
Martin Gräßlin
mgraesslin at kde.org
Fri Mar 6 07:10:27 UTC 2015
> On March 5, 2015, 4:44 p.m., Lukáš Tinkl wrote:
> > For posterity, does this still work with khotkeys?
why should it not work with khotkeys? Or better said: what should be so special about khotkeys?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/#review77063
-----------------------------------------------------------
On Feb. 26, 2015, 10:39 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122590/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 10:39 p.m.)
>
>
> Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
>
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.
>
>
> Diffs
> -----
>
> src/kglobalaccel.h 4a5595f
> src/kglobalaccel.cpp d123af4
> src/kglobalaccel_p.h b1528dc
>
> Diff: https://git.reviewboard.kde.org/r/122590/diff/
>
>
> Testing
> -------
>
> screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150306/8f8d78f2/attachment.html>
More information about the Kde-frameworks-devel
mailing list