Review Request 122779: Make KFileItemDelegate handle non default devicePixelRatio in animations
Marco Martin
notmart at gmail.com
Thu Mar 5 15:21:27 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122779/#review77061
-----------------------------------------------------------
+1
- Marco Martin
On March 2, 2015, 5:07 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122779/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 5:07 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> KIO::CachedRendering creates new pixmaps that hold transitional states in animation, these pixmap sizes need to be in device pixels.
>
>
> Diffs
> -----
>
> src/widgets/delegateanimationhandler.cpp 16035ca
> src/widgets/delegateanimationhandler_p.h 292364f
> src/widgets/kfileitemdelegate.cpp 90bce37
>
> Diff: https://git.reviewboard.kde.org/r/122779/diff/
>
>
> Testing
> -------
>
> Ran systemsettings with Qt::AA_UseHighDpiPixmaps and QT_DEVICE_PIXEL_RATIO=2
>
> hovering over the main view no longer makes the icon blocky.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150305/f7f91ccb/attachment.html>
More information about the Kde-frameworks-devel
mailing list