Review Request 122799: Simple fix for huge icon sizes on some monitors

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122799/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Currently units is mostly based on font metrics except icon size and some SVG
parts which use DPI directly.

Instead of taking the physical DPI we take the logical DPI which is used
for working out font point -> pixel sizes by everything else. This keeps everything to be loosely based on font sizes.
It can also be overriden by the user in systemsettings -> fonts -> force fonts DPI or xdpyinfo, whereas the devicePixelRatio cannot.

We can rely on this being correct as otherwise every other app would
appear broken.

Change-Id: I22f668ccea7d6d15ff475e1368c82964bdde1e60


Diffs
-----

  src/declarativeimports/core/units.cpp 148e08c 

Diff: https://git.reviewboard.kde.org/r/122799/diff/


Testing
-------

Ran on my normal screen. Everything is the same.
Ran on a ridiculously high DPI screen, everything is better than before.

Would be good if Martin G could test on his broken screen.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150304/a3739b9e/attachment.html>