Review Request 122793: Fix KUrlNavigator with high DPI pixmaps

Aleix Pol Gonzalez aleixpol at kde.org
Tue Mar 3 17:12:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122793/#review76957
-----------------------------------------------------------


+1

- Aleix Pol Gonzalez


On March 3, 2015, 5:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122793/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 5:37 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Ported to QStyle::drawItemPixmap rather than fix the existing code to
> manually center align an icon in a rectangle as it does the same thing for us properly.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kurlnavigatorplacesselector.cpp 45d7f5a 
>   src/filewidgets/kurlnavigatortogglebutton.cpp 0c5f421 
> 
> Diff: https://git.reviewboard.kde.org/r/122793/diff/
> 
> 
> Testing
> -------
> 
> Ran new test app with QT_DEVICE_PIXEL_RATIO=2
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150303/32be188d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list