Review Request 122788: Fix kdoctools_encode_uri() cmake macro call
Luigi Toscano
luigi.toscano at tiscali.it
Tue Mar 3 12:16:14 UTC 2015
> On March 3, 2015, 1:13 p.m., Luigi Toscano wrote:
> > Does it mean that it's not working right now?
Right, it does not. The symmetrical patch on kdelibs4support has:
kdelibs4support_encode_uri(DocBookXML4_DTD_DIR)
http://quickgit.kde.org/?p=kdelibs4support.git&a=commitdiff&h=315e660886ea3809db2139bb2ffc16e915792829&hp=43febf490507eda6f56c4537585f351dd31e25e9
Ok, thanks.
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122788/#review76946
-----------------------------------------------------------
On March 3, 2015, 1:09 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122788/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 1:09 p.m.)
>
>
> Review request for KDE Frameworks and Luigi Toscano.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> It takes a variable reference rather than a value, so it can provide some output.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 468e450
>
> Diff: https://git.reviewboard.kde.org/r/122788/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150303/f6f710ec/attachment.html>
More information about the Kde-frameworks-devel
mailing list