Review Request 122774: Fix logic error in qpixmap/image item

Luca Beltrame lbeltrame at kde.org
Mon Mar 2 16:16:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122774/#review76906
-----------------------------------------------------------

Ship it!


Oops, copy-paste error on my part... thanks for spotting!

- Luca Beltrame


On Mar. 2, 2015, 2:43 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122774/
> -----------------------------------------------------------
> 
> (Updated Mar. 2, 2015, 2:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> sourceRect is used to see if the destination rect changes since the
> previous update, this value is stored in m_paintedRect, m_image.rect()
> is constant
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 
> 
> Diff: https://git.reviewboard.kde.org/r/122774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150302/20aeddd9/attachment.html>


More information about the Kde-frameworks-devel mailing list