Review Request 122576: Introduce KMoreTools

Gregor Mi codestruct at posteo.org
Sun Mar 1 14:28:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/
-----------------------------------------------------------

(Updated March 1, 2015, 2:28 p.m.)


Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.


Changes
-------

API refactoring, fix mem handling issue, remove std::shared_ptr


Repository: kservice


Description
-------

Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/

Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework

If KMoreTools is considered useful it needs a home. I placed it in KService for now.


Diffs (updated)
-----

  CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 
  src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 
  src/kmoretools/kmoretools.h PRE-CREATION 
  src/kmoretools/kmoretools.cpp PRE-CREATION 
  src/kmoretools/kmoretools_p.h PRE-CREATION 
  src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION 
  src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION 
  src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION 
  tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e 
  tests/kmoretools/1/a.desktop PRE-CREATION 
  tests/kmoretools/1/b.desktop PRE-CREATION 
  tests/kmoretools/1/c.desktop PRE-CREATION 
  tests/kmoretools/2/kate.desktop PRE-CREATION 
  tests/kmoretools/2/kate.png PRE-CREATION 
  tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION 
  tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION 
  tests/kmoretools/kmoretoolstest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122576/diff/


Testing
-------


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150301/a415f9e1/attachment.html>


More information about the Kde-frameworks-devel mailing list