Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

[Romário Rios]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
-----------------------------------------------------------

(Updated June 28, 2015, 10:31 a.m.)


Review request for KDE Frameworks.


Changes
-------

Changed to the three ifs and also added tests


Repository: karchive


Description
-------

The KArchiveFile::copyTo() doesn't set the permissions of the files it copies -- it just copies the data. So if an archive contains an executable, it's extracted from the archive as a non-executable. This patch makes it apply the executable permissions found in the KArchiveFile to the QFile being copied.


Diffs (updated)
-----

  autotests/karchivetest.cpp afc8387 
  src/karchive.cpp 344cba8 

Diff: https://git.reviewboard.kde.org/r/124165/diff/


Testing
-------

Seems to work for all files (tested with xz and zip files containing executables, directories, text, etc.).


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150628/96b10f90/attachment.html>